Skip to content

fix: prevent crash when encoding payload with invalid UTF-8 #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agity7 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix: prevent crash when encoding payload with invalid UTF-8 #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lua/codeium/io.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ function M.gunzip(path, callback)
vim.o.shell = "powershell"
end
vim.o.shellcmdflag =
"-NoLogo -NoProfile -ExecutionPolicy RemoteSigned -Command [Console]::InputEncoding=[Console]::OutputEncoding=[System.Text.Encoding]::UTF8;"
"-NoLogo -NoProfile -ExecutionPolicy RemoteSigned -Command [Console]::InputEncoding=[Console]::OutputEncoding=[System.Text.Encoding]::UTF8;"
vim.o.shellredir = "2>&1 | Out-File -Encoding UTF8 %s; exit $LastExitCode"
vim.o.shellpipe = "2>&1 | Out-File -Encoding UTF8 %s; exit $LastExitCode"
vim.o.shellquote = ""
Expand Down Expand Up @@ -402,12 +402,18 @@ function M.post(url, params)
local tmpfname = os.tmpname()

if type(params.body) == "table" then
local f = io.open(tmpfname, 'w+')
local ok, json = pcall(vim.fn.json_encode, params.body)
if not ok then
log.error("Failed to encode Codeium payload (invalid UTF-8?)")
return
end

local f = io.open(tmpfname, "w+")
if f == nil then
log.error('Cannot open temporary message file: ' .. tmpfname)
log.error("Cannot open temporary message file: " .. tmpfname)
return
end
f:write(vim.fn.json_encode(params.body))
f:write(json)
f:close()

params.headers = params.headers or {}
Expand Down