-
Notifications
You must be signed in to change notification settings - Fork 0
feature/SOF-7776 update: add wfn amplitude property #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| type Schema = WavefunctionAmplitudePropertySchema; | ||
|
|
||
| export class WavefunctionAmplitudeConfig extends TwoDimensionalHighChartConfigMixin { | ||
| readonly tooltipXAxisName: string = "z coordinate"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coordinate
|
|
||
| describe("WavefunctionAmplitudeProperty", () => { | ||
| const config: Omit<WavefunctionAmplitudePropertySchema, "name"> = { | ||
| xDataArray: [-6.0, -5.0, -4.0, -3.0, -2.0, -1.0, 0.0, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take example from esse?
|
|
||
| it("should handle multiple wavefunction series", () => { | ||
| const multiSeriesConfig: Omit<WavefunctionAmplitudePropertySchema, "name"> = { | ||
| xDataArray: [-2.0, -1.0, 0.0, 1.0, 2.0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid repeating twice
|
|
||
| readonly yAxisTitle: string = "Amplitude"; | ||
|
|
||
| readonly xAxisTitle: string = "Z Coordinate"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coordinate
No description provided.