[pull] main from commontoolsinc:main #203
Merged
+469
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix sink benchmarks * added mentionable charm benchmark * added missing commits + shrank runs to 100x instead of 1000x * more missing tx.commits * wrap writes in individual transactions * and more tx wrapper around cell creation * perf: defer History.claim() validation to commit time Remove O(n²) History.claim() validation during reads - each read no longer validates against all previous reads. Validation now happens once at commit time against the replica. Changes: - Replace History.claim() with History.put() in read path - History.put() now only stores first read (doesn't overwrite) - Updated test to expect commit-time validation instead of read-time Benchmark results (100 notes, 1000 reads): - Before: 16.3s - After: 2.6s (6x faster) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )