[pull] main from commontoolsinc:main #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(notes): improve notebook UI and support arbitrary charms Notebook improvements: - Add drag-drop support within notebook lists (drop onto nested notebooks) - Hide nested notebooks/notes from Patterns list (isHidden: true at creation) - "Create Another" button no longer navigates away on final "Create" - Select All footer appears only when >1 items, properly aligned with table - Support dropping any charm type (not just notes/notebooks) into notebooks - Use ct-table for consistent row spacing matching default-app Default-app changes: - Rename header from "Pages" to "Patterns" - Add drop-onto-notebook handler for drag-drop from Patterns list 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: trigger CI * style: format notebook and default-app 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: prefix unused variables with underscore 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: tonyespinoza1 <tonyespinoza1@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* fix(notes): use lift() for reactive noteCount tracking The computed(() => notes.length) pattern wasn't properly tracking reactive changes to the notes array. Using lift() with explicit dependency passing ensures proper reactive updates. Fixes: notes created in notebooks weren't appearing because noteCount stayed at 0 even when notes were added. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: format notebook and notes-import-export 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: tonyespinoza1 <tonyespinoza1@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ons (#2404) Apply the same reactivity fix pattern to hasParentNotebooks and hasSiblingNotebooks display conditions. Without lift(), the .length access inside computed() doesn't properly track reactive changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: tonyespinoza1 <tonyespinoza1@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )