forked from Exiled-Official/EXILED
-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Adds a new event for when SCP-1576 stops being used #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michcio15
wants to merge
7
commits into
ExMod-Team:master
Choose a base branch
from
michcio15:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone-193
requested changes
Dec 22, 2025
Collaborator
Someone-193
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a very good PR, could use some changes though to better conform to Exileds standards. Nice job 👍!
EXILED/Exiled.Events/EventArgs/Scp1576/TransmissionEndedEventArgs.cs
Outdated
Show resolved
Hide resolved
EXILED/Exiled.Events/EventArgs/Player/Scp1576TransmissionEndedEventArgs.cs
Show resolved
Hide resolved
EXILED/Exiled.Events/EventArgs/Scp1576/TransmissionEndedEventArgs.cs
Outdated
Show resolved
Hide resolved
EXILED/Exiled.Events/Patches/Events/Scp1576/TransmissionEnded.cs
Outdated
Show resolved
Hide resolved
EXILED/Exiled.Events/Patches/Events/Scp1576/TransmissionEnded.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: @Someone <45270312+Someone-193@users.noreply.github.com>
Author
|
I think i changed it to match your suggestions |
Change comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Adds a new event which is invoked after a player stop "talking with the dead" using scp - 1576
What is the current behavior? (You can also link to an open issue here)
Well there is no
What is the new behavior? (if this is a feature change)
The event exists
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other