Skip to content

fix: New-TablePercentageBar - rendering with conditional formatting in v1.14.0+ #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrzemyslawKlys merged 2 commits into from
Dec 29, 2025
Merged

fix: New-TablePercentageBar - rendering with conditional formatting in v1.14.0+ #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f75a8ad
fix: optimize JSON conversion and regex handling in percentage bar re…
smasterson Dec 28, 2025
2b50f12
Merge branch 'master' into fix-tablepercentagebar
PrzemyslawKlys Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Private/New-TablePercentageBarInternal.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
)

if ($ConditionalFormatting) {
$JsonConditions = $ConditionalFormatting | ConvertTo-Json
$JsonConditions = $ConditionalFormatting | ConvertTo-Json -Compress
[ordered]@{
targets = $ColumnID
render = "`$.fn.dataTable.render.percentBar('$Type','$TextColor', '$BorderColor', '$BarColor', '$BackgroundColor', $RoundValue, '$BorderStyle', $JsonConditions)"
Expand All @@ -70,4 +70,4 @@
render = "`$.fn.dataTable.render.percentBar('$Type','$TextColor', '$BorderColor', '$BarColor', '$BackgroundColor', $RoundValue, '$BorderStyle')"
}
}
}
}
7 changes: 6 additions & 1 deletion Public/New-HTMLTable.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,7 +1285,12 @@
# Before: "display": "$.fn.dataTable.Responsive.display.childRowImmediate"
# After: "display": $.fn.dataTable.Responsive.display.childRowImmediate
$Options = $Options -replace '"(\$\.fn\.dataTable\.Responsive\.display\.childRowImmediate)"', '$1'
$Options = $Options -replace '"(\$\.fn\.dataTable\.render\.percentBar\(.+\))"', '$1'
# $Options = $Options -replace '"(\$\.fn\.dataTable\.render\.percentBar\(.+\))"', '$1'
$Options = [regex]::Replace(
$Options,
'(?s)"(\$\.fn\.dataTable\.render\.percentBar\(.+?\))"',
{ param($m) ($m.Groups[1].Value -replace '\\\"', '"' -replace '\\u0027', "'" ) }
)
# we need to cleanup $Options for columnDefs/render, remove \r\n
#$Options = $Options -replace '\\r\\n', '\r\n' #-replace "\\`"",'"'

Expand Down
Loading