Use central reusable website CI workflow#1227
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3914acecce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.github/workflows/website-ci.yml
Outdated
| if [ -n "${PLAYWRIGHT_BROWSERS_PATH:-}" ] && [ -d "${PLAYWRIGHT_BROWSERS_PATH}" ]; then | ||
| rm -rf "${PLAYWRIGHT_BROWSERS_PATH}" | ||
| fi | ||
| uses: EvotecIT/PSPublishModule/.github/workflows/powerforge-website-ci.yml@codex/testimox-doctor-seo-fix |
There was a problem hiding this comment.
Pin reusable workflow to an immutable ref
Calling the reusable workflow via the branch ref @codex/testimox-doctor-seo-fix makes website-ci non-deterministic and brittle: if that branch is force-pushed or deleted after the upstream PR is merged/cleaned up, this workflow will start failing before any job steps run. Pinning to a commit SHA (or a stable tag) avoids sudden CI breakage and keeps review/build behavior reproducible.
Useful? React with 👍 / 👎.
IntelligenceX ReviewReviewing PR #1227: Use central reusable website CI workflow Merge blockers: items in Todo List ✅ and Critical Issues
Summary 📝This PR is mostly a cleanup/migration: the website CI now delegates to a pinned reusable workflow, and the website theme gains new API docs UI styles. The workflow change looks correct and improves maintainability; I did not find any merge-blocking issues in the diff provided. Todo List ✅None. Other Issues 🧯
Other Reviews 🧩
Tests / Coverage 🧪
Next Steps 🚀
Static Analysis Policy 🧭
Static Analysis 🔎
IntelligenceX thread triageAssessed commit: Diff range: PR base → head (66eaa6d..73fe47f) Needs attention:
Model & Usage 🤖
|
.github/workflows/website-ci.yml
Outdated
| if [ -n "${PLAYWRIGHT_BROWSERS_PATH:-}" ] && [ -d "${PLAYWRIGHT_BROWSERS_PATH}" ]; then | ||
| rm -rf "${PLAYWRIGHT_BROWSERS_PATH}" | ||
| fi | ||
| uses: EvotecIT/PSPublishModule/.github/workflows/powerforge-website-ci.yml@codex/testimox-doctor-seo-fix |
There was a problem hiding this comment.
Pin this reusable workflow to an immutable commit SHA (or stable tag), not a branch name; branch refs make CI non-reproducible and can fail if the branch is rewritten or deleted.
There was a problem hiding this comment.
IntelligenceX triage: The workflow reference has been updated from a branch ref to a specific commit SHA, satisfying the request to pin it immutably. (resolve failed: primary: GitHub GraphQL request returned errors: {"data":{"resolveReviewThread":null},"errors":[{"type":"FORBIDDEN","path":["resolveReviewThread"],"extensions":{"saml_failure":false},"locations":[{"line":2,"column":3}],"message":"Resource not accessible by integration"}]}; fallback: GitHub GraphQL request returned errors: {"data":{"resolveReviewThread":null},"errors":[{"type":"FORBIDDEN","path":["resolveReviewThread"],"extensions":{"saml_failure":false},"locations":[{"line":2,"column":3}],"message":"Resource not accessible by integration"}]})
Assessed commit: 3da23f8
Summary
EvotecIT/PSPublishModule@a9f52fd6a17cb066fbdfa7e451ac6d30898cef554751f06a2a52d926fc222a709ea6f0fff3d022c7until it adopts an engine lock fileDependency
Notes