Fix debug adapter reconnection in attach mode with ReconnectableDebugController #1594
Quality Gate success
Quality Gate passed
Issues
Measures
0 Security Hotspots
No data about coverage (0.00% Estimated after merge)
0.00% Duplicated Code (2.70% Estimated after merge)
Project ID: OneScript
Annotations
Check notice on line 184 in src/OneScript.DebugServices/ReconnectableDebugController.cs
sonar-openbsl-ru-qa-bot / SonarQube Code Analysis
src/OneScript.DebugServices/ReconnectableDebugController.cs#L184
Change ReconnectableDebugController.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.
Check notice on line 52 in src/OneScript.DebugServices/ReconnectableDebugController.cs
sonar-openbsl-ru-qa-bot / SonarQube Code Analysis
src/OneScript.DebugServices/ReconnectableDebugController.cs#L52
Use 'ObjectDisposedException.ThrowIf' instead of explicitly throwing a new exception instance
Check warning on line 22 in src/OneScript.DebugServices/ReconnectableDebugController.cs
sonar-openbsl-ru-qa-bot / SonarQube Code Analysis
src/OneScript.DebugServices/ReconnectableDebugController.cs#L22
Fix this implementation of 'IDisposable' to conform to the dispose pattern.
Check notice on line 30 in src/OneScript.DebugServices/ReconnectableDebugController.cs
sonar-openbsl-ru-qa-bot / SonarQube Code Analysis
src/OneScript.DebugServices/ReconnectableDebugController.cs#L30
Change type of field '_callbackService' from 'OneScript.DebugProtocol.IDebugEventListener' to 'OneScript.DebugServices.TcpEventCallbackChannel?' for improved performance
Check notice on line 24 in src/OneScript.DebugServices/ReconnectableDebugController.cs
sonar-openbsl-ru-qa-bot / SonarQube Code Analysis
src/OneScript.DebugServices/ReconnectableDebugController.cs#L24
Remove the field '_port' and declare it as a local variable in the relevant methods.
Check notice on line 28 in src/OneScript.DebugServices/ReconnectableDebugController.cs
sonar-openbsl-ru-qa-bot / SonarQube Code Analysis
src/OneScript.DebugServices/ReconnectableDebugController.cs#L28
Change type of field '_server' from 'OneScript.DebugProtocol.Abstractions.ICommunicationServer' to 'OneScript.DebugProtocol.TcpServer.DefaultMessageServer<OneScript.DebugProtocol.TcpServer.RpcCall>?' for improved performance
Check warning on line 16 in src/OneScript.DebugServices/TcpEventCallbackChannel.cs
sonar-openbsl-ru-qa-bot / SonarQube Code Analysis
src/OneScript.DebugServices/TcpEventCallbackChannel.cs#L16
Fix this implementation of 'IDisposable' to conform to the dispose pattern.

7 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)