v2 к #1295: работа параметра runtime.default

[Mr-Rm]

Установка параметра runtime.default=native не срабатывала, если компилируемый модуль не содержал никаких аннотаций.
В этом случае из VisitModule() не вызывался VisitModuleAnnotation()

Summary by CodeRabbit

• Refactor
  • Streamlined module configuration: The runtime behavior is now determined solely by explicit settings from module annotations, removing fallback defaults. This update provides a more predictable and streamlined execution experience.

[coderabbitai]

Walkthrough

The changes simplify the CompilerBackendSelector class by removing the _isNativeDefault field and its related logic. The constructor now directly sets _isNative using the value from options.UseNativeAsDefaultRuntime. In addition, the VisitModuleAnnotation method no longer reassigns _isNative using a default fallback. Instead, _isNative is determined solely based on the parsed annotations.

Changes

File	Summary
src/ScriptEngine/Compiler/CompilerBackendSelector.cs	Removed the private field _isNativeDefault. Constructor now assigns _isNative directly from options.UseNativeAsDefaultRuntime. Removed fallback logic in VisitModuleAnnotation that previously set _isNative from _isNativeDefault.

Sequence Diagram(s)

sequenceDiagram
    participant Options as Options Instance
    participant Selector as CompilerBackendSelector
    participant Annotation as ModuleAnnotation

    Options->>+Selector: Instantiate with UseNativeAsDefaultRuntime
    Note over Selector: _isNative set directly from options
    Annotation->>+Selector: Call VisitModuleAnnotation()
    Note over Selector: _isNative updated based solely on annotation
    Selector-->>-Annotation: Returns after processing annotation

Loading

Poem

I'm a rabbit, swift and spry,
Hopping through code under the sky.
I nibbled off the default fields with glee,
Now logic flows smoothly, wild and free.
With clean paths and simpler flow,
I cheer the change — off we go!
🥕🐇 Happy coding, let's romp and show!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a3239d and a5fe637.

📒 Files selected for processing (1)

• src/ScriptEngine/Compiler/CompilerBackendSelector.cs (1 hunks)

🔇 Additional comments (3)

src/ScriptEngine/Compiler/CompilerBackendSelector.cs (3)

19-24: LGTM! The simplified initialization logic fixes the runtime.default parameter.

The direct initialization of _isNative from options.UseNativeAsDefaultRuntime ensures that the default runtime setting is respected even when no annotations are present in the module. This change effectively addresses the issue where runtime.default=native wasn't working for modules without annotations.

---

41-53: LGTM! The annotation processing is now more focused and maintainable.

The method now has a single responsibility of processing runtime annotations, while the default runtime handling is cleanly separated into the constructor. This design improvement makes the code more maintainable and easier to understand.

---

55-61:

Details

❓ Verification inconclusive

Verify the module processing behavior.

The method correctly processes module annotations when they exist. When no annotations are found, the default runtime setting (initialized in the constructor) is preserved, which fixes the original issue.

Let's verify this behavior with a test that ensures the default runtime is respected when no annotations are present:

---

🏁 Script executed:

#!/bin/bash
# Description: Search for tests that verify the default runtime behavior

# Look for relevant test files
rg -l "CompilerBackendSelector" --type cs | grep -i "test"

# Look for test methods related to default runtime
rg -A 5 "UseNativeAsDefaultRuntime" --type cs | grep -i "test"

Length of output: 117

---

Verify that the default runtime remains preserved without annotations.

The VisitModule method in src/ScriptEngine/Compiler/CompilerBackendSelector.cs correctly processes module annotations by calling VisitModuleAnnotation when they exist. It also preserves the default runtime (set in the constructor) when no annotations are found. However, our initial search for tests (e.g., looking for "UseNativeAsDefaultRuntime") produced no output, which means the behavior isn’t currently validated by an automated test.

• Action: Please verify manually—or add tests—to ensure that modules without annotations indeed retain the default runtime setting.
• Consideration: If tests are already present under a different naming convention, check that they effectively cover this case.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nixel2007]

А есть способ выключить нэйтив в модуле?

[Mr-Rm]

А есть способ выключить нэйтив в модуле?

Директива #stack в начале модуля