Skip to content

Conversation

@aklevans
Copy link

@aklevans aklevans commented Jul 19, 2024

Builds upon @DCS-87's implementation of pressure sensing on Windows.

Dynamically changes the monitor to output to based on mouse position. This is now on by default and is overridden when the --monitor or --region tags are used.

Additionally, the program can now be exited using Ctrl-C, which did not use to work. The only option was to close the console which made restarting a pain.

I think these changes are significant enough to be worth publishing a new version to PyPi!

@Evidlo
Copy link
Owner

Evidlo commented Nov 10, 2024

Thanks for putting the work into this. I'd be happy to merge in support for pressure on Windows, but this needs to be cleaned up quite a bit.

  1. I'd much rather the argument be called --windows or something like that. --pen isn't very descriptive.
  2. pen.py is rather messy. There are lots of unused constants, inconsistent coding style (e.g. camelcase applyPen). This file needs a refactor.
  3. Remove the automonitor feature from the PR. We can talk about adding this behavior in an issue, but it's easier if this was removed for now.

@DCS-87
Copy link

DCS-87 commented Nov 11, 2024

Yeah it's messy because I don't know much about coding, that is just me and google being happy to get it working at all. I'll let someone else take a crack at refactoring that :) I do like the dynamic monitor selection though.

@Evidlo
Copy link
Owner

Evidlo commented Nov 23, 2024

Yeah it's messy because I don't know much about coding, that is just me and google being happy to get it working at all. I'll let someone else take a crack at refactoring that :) I do like the dynamic monitor selection though.

I understand. I have to keep maintainability in mind (been maintaining this for 5 years), so I can't merge contributions in just because they work.

By the way, PRs and feedback on them is a great way to gain programming experience.

NicoM1 added a commit to NicoM1/remarkable_mouse that referenced this pull request Feb 22, 2025
…lso add platform detection so that --pressure supports windows or linux
@NicoM1
Copy link

NicoM1 commented Feb 22, 2025

Thanks for doing this @aklevans, I had a go at cleaning this up a little bit in #97. Happy to do a little more work to get this merged in as it'd be quite useful to me.

Thanks to you or @DCS-87, whoever did the pressure sensitivity code, I mostly pulled it directly with some minor cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants