Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces preliminary support for window functions in the Kriteria query DSL library. The implementation allows defining window specifications with partition and ordering clauses, and provides common aggregate functions like sum and avg that can operate over these windows.
Key changes:
- Added
KrWindowandKrWindowBuilderclasses for defining window specifications with partition and order clauses - Extended expression system to support window-based aggregate function calls through
CallAggregateExpression - Integrated window translation into the JPA translation layer with Hibernate-specific support
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Sale.kt | New test entity representing sales data with employee, amount, and date fields |
| WindowFunctionsTest.kt | Comprehensive integration test demonstrating window function usage with partitioning and aggregation |
| KrWindow.kt | Core window specification classes with builder pattern for configuration |
| CommonWindowFunctions.kt | Convenience functions for common window aggregates (sum, avg) |
| KrExpression.kt | Enhanced expression hierarchy to support window-based function calls and improved formatting |
| ExpFunction.kt | Added window-specific aggregate function call methods |
| TranslateWindow.kt | Translation logic for converting KrWindow to Hibernate's JpaWindow |
| TranslationContext.kt | Added Hibernate-specific helper for operations requiring HibernateCriteriaBuilder |
| KrQueryOrSubqueryBuilder.kt | Added window() method for creating windows in query builders |
| TranslateExpression.kt | Enhanced expression translation to handle window-based aggregate calls |
| KrQuery.kt, KrSubquery.kt | Extended query structures to include window definitions |
| TranslateQueries.kt | Integrated window translation into query processing |
| PathCache.kt | Added placeholder for window caching (not yet implemented) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
core/src/main/kotlin/fi/evident/kriteria/jpa/translation/PathCache.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fi/evident/kriteria/jpa/translation/TranslateExpression.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.