Build + upload wheel in CI #1
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": [ | ||
| "config:recommended", | ||
| "schedule:weekly" | ||
| ], | ||
| "timezone": "America/Los_Angeles", | ||
| "includePaths": [".github/**"] | ||
| } | ||
|
There was a problem hiding this comment. Sorry I'm not that familiar with renovate configuration -- what effect does this have? I assumed it mainly defined where to look for things to upgrade. Are there dependencies in this repo it'll manage? There was a problem hiding this comment. If renovate will target this repo, does it need to be added here: https://github.com/Everlaw/renovate-bot-config/blob/main/.renovate/config.js ?
Collaborator
Author
There was a problem hiding this comment.
In this case it'll probably only update
Yep! https://github.com/Everlaw/renovate-bot-config/pull/120 |
||
|
Collaborator
Author
There was a problem hiding this comment. For reference, this implementation is mostly copy-pasted from our existing CI for There was a problem hiding this comment. I'm sure ya'll considered this when implementing libpff, but I'm curious how we decided what to put in the servers repo vs what we put in the host repo? There was a problem hiding this comment. Same with the python and pip versions
Collaborator
Author
There was a problem hiding this comment.
This will get updated by Renovate like Everlaw/libpff#10... though I'm realizing we probably need to configure the bot to automatically assign reviewers 😆
Collaborator
Author
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment. Also, the "checkout" thing needs to be in this repo, because that's how we actually perform the
Collaborator
Author
There was a problem hiding this comment.
This one actually needs to be independent of what's in https://github.com/Everlaw/servers. If we were going to upgrade to, say, python3.13, we'd add a new item to so that we end up pushing acp313 wheel to S3. Then, https://github.com/Everlaw/servers would be able to download and install it.
These are just matching the original (pre-fork) constraints, so I don't expect them to ever change. In any case, the constraints for this library should be completely independent from the constraints for https://github.com/Everlaw/servers. There was a problem hiding this comment.
Would we not want to change this python version along with our global python version whenever we update? There was a problem hiding this comment. At any rate, sounds like you've got a much better understanding of this as an ecosystem than I do! Just looking out for a situation where, say, someone is updating our python version and forgets to do so here then has to get all the way through some CI build before it reports a certain artifact not being found, have to track down this repo, change it here as well etc.
Collaborator
Author
There was a problem hiding this comment.
Haha yes, that's likely how it will happen. We just need to be able to support deploying multiple artifacts (one for each downstream Python version) at the same time so that the update PR into this repo can land independent of the "main" PR into https://github.com/Everlaw/servers. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: build_wheel | ||
| on: [push] | ||
| permissions: read-all | ||
| jobs: | ||
| build_wheel: | ||
| strategy: | ||
| matrix: | ||
| python-version: | ||
| - 3.12.6 | ||
| runs-on: [self-hosted, fasttext] | ||
|
Collaborator
Author
There was a problem hiding this comment. The |
||
| steps: | ||
| - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 | ||
| - name: Install Python | ||
| run: | | ||
| uv python install ${{ matrix.python-version }} | ||
| - name: Create virtual environment | ||
| run: | | ||
| rm -rf venv | ||
| uv venv --python ${{ matrix.python-version }} venv | ||
| echo "$(pwd)/venv/bin" >> $GITHUB_PATH | ||
| - name: Build wheel | ||
| run: | | ||
| rm -rf dist | ||
| uv build --out-dir dist | ||
| - name: Check wheel | ||
| run: | | ||
| # These requirements were lifted from `install_requires` in `setup.py`. | ||
| uv pip install \ | ||
| 'pybind11>=2.2' \ | ||
| 'setuptools>=0.7.0' \ | ||
| 'numpy' | ||
| uv pip install --no-index --find-links dist fasttext | ||
|
Comment on lines
+27
to
+32
Collaborator
Author
There was a problem hiding this comment. The goal here is to install the |
||
| python -c 'import fasttext' | ||
| - name: Upload wheel | ||
| run: | | ||
| ./upload-wheel.sh dist/fasttext*.whl | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners | ||
| * @Everlaw/developer-experience-squad |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| [metadata] | ||
| description_file = README.md |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ | |
| import platform | ||
| import io | ||
|
|
||
| __version__ = "0.9.4.rc0" | ||
|
Collaborator
Author
There was a problem hiding this comment. Once we're satisfied with testing https://github.com/Everlaw/servers/pull/39905, we should remove the |
||
| FASTTEXT_SRC = "src" | ||
|
|
||
| # Based on https://github.com/pybind/python_example | ||
|
|
@@ -194,6 +194,7 @@ def _get_readme(): | |
| "Operating System :: Unix", | ||
| "Operating System :: MacOS", | ||
| ], | ||
| # These requirements are duplicated in `.github/workflows/build_wheel.yml`. | ||
| install_requires=["pybind11>=2.2", "setuptools >= 0.7.0", "numpy"], | ||
| cmdclass={"build_ext": BuildExt}, | ||
| packages=[ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| wheel="$1" | ||
| url="s3://everlaw-build-artifacts/fasttext/$(basename "$wheel")" | ||
|
|
||
| if aws s3 ls "$url" &>/dev/null; then | ||
| >&2 echo "$url already exists!" | ||
| exit 0 | ||
| fi | ||
|
|
||
| aws s3 cp --only-show-errors "$wheel" "$url" | ||
|
Collaborator
Author
There was a problem hiding this comment. The runner has permission to do this because of https://github.com/Everlaw/servers/pull/39903. |
||
| >&2 echo "Uploaded $url" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also copy-pasted from elsewhere: https://github.com/Everlaw/libpff/blob/master/.github/renovate.json5.