Skip to content

MBP-330: Brake with diagnostic function#36

Open
mac-kan wants to merge 4 commits intomasterfrom
MBP-330-Brake-With-Diagnostic-Function
Open

MBP-330: Brake with diagnostic function#36
mac-kan wants to merge 4 commits intomasterfrom
MBP-330-Brake-With-Diagnostic-Function

Conversation

@mac-kan
Copy link
Copy Markdown
Collaborator

@mac-kan mac-kan commented Oct 30, 2025

No description provided.

@mac-kan mac-kan self-assigned this Oct 30, 2025
@mac-kan mac-kan force-pushed the MBP-330-Brake-With-Diagnostic-Function branch from 3b7ab60 to be672ca Compare October 31, 2025 10:36
@mac-kan mac-kan marked this pull request as ready for review October 31, 2025 10:40
@mac-kan mac-kan changed the title MBP-330-Brake with diagnostic function MBP-330: Brake with diagnostic function Jan 15, 2026
Copy link
Copy Markdown
Member

@federrg federrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I am wrong. Currently, it is just a boolean output. Meaning that it can only be linked to one of the diagnostic channels of the EL2044.
The EL2044 has

Image

IF this is meant to only be linked to the open load diagnostics, I would change the variable name to that. If it is meant to be linked to more inputs, then we need to do something about that in the code.
@AlSallami7 is open load enough?

@federrg federrg requested a review from AlSallami7 February 9, 2026 12:29
@AlSallami7
Copy link
Copy Markdown
Collaborator

To ensure safe operation, I recommend linking the inputs for open load, overcurrent, and short circuit.

@federrg
Copy link
Copy Markdown
Member

federrg commented Feb 18, 2026

Hi I have decided to go for one variable to link to the status word and then we will compare that with masks to see if any of those errors are present.

@mac-kan
Copy link
Copy Markdown
Collaborator Author

mac-kan commented Feb 18, 2026

@federrg I think that is a good decision. I'll fix that asap.

@mac-kan
Copy link
Copy Markdown
Collaborator Author

mac-kan commented Feb 20, 2026

@federrg Follow up:
Should we prepare four words then, i.e. one word for all channels of EL2044?
Should the unmasking be done into booleans in the ST_AxisStatus: e.g. .bBrakeDiagOvercurrent etc?

Adds an input word to facilitate mapping diagnostics from e.g. an
EL2044 terminal to monitor if the output fails.

Adds status variables for brake diagnostics.
Masks the brake terminal diagnostics word and maps to two AxisStatus
variables.
Adds the diagnostic input signal to the external brake code to prevent
unwanted motion when the diagnostic input fails. Since the input
variable defaults to TRUE, it is still possible to use the external
brake functionality without connecting the diagnostic input variable to
any I/O.
@mac-kan mac-kan force-pushed the MBP-330-Brake-With-Diagnostic-Function branch from be672ca to bd7636f Compare February 20, 2026 09:10
@mac-kan mac-kan requested a review from federrg February 20, 2026 09:16
@federrg
Copy link
Copy Markdown
Member

federrg commented Feb 20, 2026

@federrg Follow up: Should we prepare four words then, i.e. one word for all channels of EL2044? Should the unmasking be done into booleans in the ST_AxisStatus: e.g. .bBrakeDiagOvercurrent etc?

@mac-kan I do not think we need 4 words. Just one word per ST_Axis for the brake is enough. To be honest I would have just one status called something like bBrakeError and link all the status as or to them. For troubleshooting then we can go into the status word.
What do you think @AlSallami7 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants