Skip to content

Eureka 4.x & Swift 4 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yelles wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Eureka 4.x & Swift 4 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6830548
Updating podspec to allow interop with Eureka 4.x
Yelles Nov 1, 2018
1b64fa3
Add Objc reference
Yelles Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FloatLabelRow.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ Pod::Spec.new do |s|
s.requires_arc = true
s.ios.source_files = ['Sources/**/*.{swift}']
s.ios.frameworks = 'UIKit', 'Foundation'
s.dependency 'Eureka', '~> 3.0'
s.dependency 'Eureka', '>= 3.0'
end
2 changes: 1 addition & 1 deletion Sources/FloatLabelRow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ open class _FloatLabelCell<T>: Cell<T>, UITextFieldDelegate, TextFieldCell where
return NSLayoutConstraint.constraints(withVisualFormat: "H:|-[floatLabeledTextField]-|", options: .alignAllLastBaseline, metrics: metrics, views: views) + NSLayoutConstraint.constraints(withVisualFormat: "V:|-(vMargin)-[floatLabeledTextField]-(vMargin)-|", options: .alignAllLastBaseline, metrics: metrics, views: views)
}

open func textFieldDidChange(_ textField: UITextField) {
@objc open func textFieldDidChange(_ textField: UITextField) {
guard let textValue = textField.text else {
row.value = nil
return
Expand Down