fix: fix and reactivate crusading event#256
Closed
OH296 wants to merge 10 commits intoEttyKitty:developmentfrom
Closed
fix: fix and reactivate crusading event#256OH296 wants to merge 10 commits intoEttyKitty:developmentfrom
OH296 wants to merge 10 commits intoEttyKitty:developmentfrom
Conversation
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
Warning Rate limit exceeded@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 42 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (35)
WalkthroughThese changes update various data, object, and script files across the project, nyan. Data files have revised configuration entries and updated instructions for custom icons, while JSON files for psychic disciplines and powers have been modified, nyan. Object scripts now adjust role requirements and add a try‑catch error handling block for stability, nyan. Several script files have been reformatted for consistency and updated to improve gameplay logic—such as dynamic crusade assignment and fleet movement—and to clean up debug outputs, nyan. Changes
Sequence Diagram(s)sequenceDiagram
participant GE as "Game Engine"
participant S0 as "Step_0.gml"
participant EH as "handle_exception()"
GE->>S0: Execute menu, audio, & cheat code logic
alt Successful Execution
S0-->>GE: Continue normal processing
else Exception Occurs
S0->>EH: Call handle_exception(_exception)
EH-->>GE: Error handling response returned
end
sequenceDiagram
participant LC as "launch_crusade()"
participant PF as "get_nearest_player_fleet()"
participant VT as "get_viable_travel_time()"
participant GL as "Game Log"
LC->>PF: Retrieve nearest player fleet using star coords
alt Fleet Found
LC->>VT: Compute dynamic travel time (ETA)
VT-->>LC: Return computed ETA
LC->>GL: Log event and display popup with ETA
LC->>LC: Assign crusade with random planet selection
else No Fleet Found
LC-->>LC: Return false (no fleet available)
end
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
PR: Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of changes
make the crusading event naturally spawn in game again
also make some improvements to code base
ensure crusades are always reachable by player by creating get_viable_travel_time function which uses the fastest route algorithm to ensure a location can always be reached by at least 1 fleet with a margin of 10 turns
Describe the solution
Testing done
us "event crusade" cheat to spawn crusade and send player fleet on crusade
Related links
None
Custom player notes entry
Use the PR title.
Summary by CodeRabbit
New Features
Documentation
Gameplay Improvements
UI Enhancements