GH-1257 Allow executing other commands in custom command feature. #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vLuckyyy
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a feature to execute a list of commands when a custom command is used. The implementation correctly adds a commands list to CustomCommand and handles their execution in CustomCommandBukkitWrapper. My review includes a critical fix for a potential NullPointerException that can occur if the commands list is omitted in the configuration, and a suggestion to refactor duplicated code in the CustomCommand constructors for better maintainability.
eternalcore-core/src/main/java/com/eternalcode/core/feature/customcommand/CustomCommand.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/customcommand/CustomCommand.java
Outdated
Show resolved
Hide resolved
…ult initialization for commands.
vLuckyyy
changed the title
Jakubk15
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.