GH-201 Disable drop feature entirely if dropType is unchanged #203

Jakubk15 · 2025-02-08T21:21:50Z

resolves #201

coderabbitai · 2025-02-08T21:21:57Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

igoyek

god

CitralFlo

All Gucci

Rollczi

No trochę słabo bo my mamy API i tam to nadal będzie dostępne

Jakubk15 · 2025-02-15T07:44:19Z

No trochę słabo bo my mamy API i tam to nadal będzie dostępne

We'll discuss this today if I feel well (I kinda feel sick rn)

Jakubk15 · 2025-03-16T16:44:23Z

will fix later dw

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Make readme great again. * Fix table. * Update README.md * Update readme banner.

* Ignore thorns damage * Simply if else statement

Took 6 minutes

…st reasons for kick ex. "Server restart" and untagall command (#221) * - Added Event priority to config. * - Some modifications * Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/logout/LogoutController.java Co-authored-by: Michał Wojtas <80779749+CitralFlo@users.noreply.github.com> * Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/logout/LogoutController.java Co-authored-by: Michał Wojtas <80779749+CitralFlo@users.noreply.github.com> * Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/logout/LogoutController.java Co-authored-by: Michał Wojtas <80779749+CitralFlo@users.noreply.github.com> * Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/logout/LogoutController.java Co-authored-by: Michał Wojtas <80779749+CitralFlo@users.noreply.github.com> * Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/logout/LogoutController.java Co-authored-by: Michał Wojtas <80779749+CitralFlo@users.noreply.github.com> * Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/logout/LogoutController.java Co-authored-by: Michał Wojtas <80779749+CitralFlo@users.noreply.github.com> * - Added whitelist reasons for punishments * - Added whitelist reasons for punishments * - Fixed description in CombatSettings * - Made untag command also executeable via console - Added untagall command to untag all tagged players at once. useful in cases when you want to do something related to events. * - Better way of untagging all players. * - Needs testing - head drops #214 #214 * - Added bypass checks for combat * - Changed the way how bypass is being detected. Using function FightTagController#cannotBeTagged * - Disabling elytra when get tagged when you are moving. Currently there is a bug where you can still can fly if you are already flying when getting tagged. * Remove event declaration duplications by DynamicListener and EventManager --------- Co-authored-by: Michał Wojtas <80779749+CitralFlo@users.noreply.github.com> Co-authored-by: Rollczi <ndejlich5@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…y checked root commands (#225) * Add better way to check restricted command - previous idea only checked root commands Took 2 minutes * Code review --------- Co-authored-by: Rollczi <ndejlich5@gmail.com>

…ions in knockback feature (#227) * Sort combat regions by priority which supports overlapping regions in knockback feature * Sort combat regions by priority which supports overlapping regions in knockback feature * Resolve DMK and jakubek review's * Correct priority

* Add Lands support. * Fix. * Fix support. * Remove useless code. Fix lands implementation. Fix a force knockback system. Fix configuration reloads for border features. Improve default border particle configuration for a better client experience (more fps) * Fix triggers indexing. Update border on tag event * Cleanup * Resolve conflicts --------- Co-authored-by: Rollczi <ndejlich5@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… v4.23.0 (#230) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix head drop Signed-off-by: vLuckyyy <vluckyyy.biznes@gmail.com> * Add minimessages coloring to head drops. --------- Signed-off-by: vLuckyyy <vluckyyy.biznes@gmail.com>

* Fix pearl cooldown Signed-off-by: vLuckyyy <vluckyyy.biznes@gmail.com> * Fix cooldown. --------- Signed-off-by: vLuckyyy <vluckyyy.biznes@gmail.com>

…15.20 (#234) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…to v3.2.1 (#235) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….gradle.plugin to v8.3.8 (#236) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

@imDMK

* Init * Add anchor support * Add anchor to api * Add meta data contants create static methods to retrive uuid. Follow @imDMK and @coderabbitai reviews * Use coderabbit suggestion to version compatibility * Follow coderabbit review * Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/crystalpvp/CrystalPvpConstants.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Resolve review. Add documentation comment, add ignored worlds check and event.cancelled check. Fix method name to use `UniqueId` instead of `UUID` * Remove isCancelled() check -> follow coderabbit <3 * follow coderabbit - add one check for hasDamagerBlockState method declaration check * Resolve vLuckyyy review * e -> exception rename --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

# Conflicts: # eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java

Jakubk15 added 2 commits February 8, 2025 22:09

Disable drop feature entirely if DropType equals UNCHANGED

76d5b6d

comment out dependsOn from shadowJar task

abcbcb3

Jakubk15 requested review from a team, CitralFlo, Rollczi, igoyek and vLuckyyy February 8, 2025 21:21

Jakubk15 added the 🐛 bug Something isn't working label Feb 8, 2025

Jakubk15 changed the title ~~v2.0/angelchest-compat~~ GH-201 Disable drop feature entirely if dropType is unchanged Feb 8, 2025

Clarify comment in config

2ab0a42

igoyek approved these changes Feb 8, 2025

View reviewed changes

vLuckyyy approved these changes Feb 8, 2025

View reviewed changes

CitralFlo approved these changes Feb 8, 2025

View reviewed changes

Rollczi reviewed Feb 14, 2025

View reviewed changes

Jakubk15 linked an issue Feb 15, 2025 that may be closed by this pull request

[BUG] add angelchest compatibility #201

Closed

Merge branch '2.0' into v2.0/angelchest-compat

fe034df

Jakubk15 and others added 11 commits March 16, 2025 21:33

fix build

1ac36b8

GH-189 EternalCombat 2.0. (#189)

726f1aa

GH-190 Remove unused dependencies.

da555c6

Update ShadowJar and gradle.

f338fc4

Update renovate settings and remove whitesource.

bd4fd13

dependency: Update minor (#210)

8c5038e

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Fix java settings.

7f13049

GH-186 Make readme great again. (#208)

4cd8367

* Make readme great again. * Fix table. * Update README.md * Update readme banner.

Merge branch '2.0' into v2.0/angelchest-compat

95fb636

fix imports

f81237c

announcer -> noticeService

824313c

vLuckyyy added 5 commits March 26, 2025 19:36

Release v2.0.1-SNAPSHOT.

bae1b80

Fix time formatting for combat message.

d9f98d3

Fix PlayerTeleportEvent warn message.

0509585

Fix placeholder in "adminPlayerNotInCombat"

7f30d79

Release v2.0.1

312d8e0

CitralFlo mentioned this pull request Mar 29, 2025

Drop player head after death #214

Closed

Rollczi and others added 22 commits April 22, 2025 20:54

GH-217 Fix NPE in BorderBlockController (#217)

a8b48b8

GH-220 Ignore thorns when causing combat log (#220)

31d41c9

* Ignore thorns damage * Simply if else statement

GH-213 Fix bossbar configuration serialization (#213)

411e78d

Add option to display milliseconds for last second of combat (#219)

2dc6cbf

Took 6 minutes

dependency: Update minor (#215)

b87e640

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

GH-225 Add better way to check restricted command - previous idea onl…

d6bf4e6

…y checked root commands (#225) * Add better way to check restricted command - previous idea only checked root commands Took 2 minutes * Code review --------- Co-authored-by: Rollczi <ndejlich5@gmail.com>

Release v2.1.0

9e914d6

dependency: Update minor (#228)

f2ab289

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

dependency: Update dependency net.kyori:adventure-text-minimessage to…

ba5fa97

… v4.23.0 (#230) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

GH-232 Fix head drop (#232)

487fc97

* Fix head drop Signed-off-by: vLuckyyy <vluckyyy.biznes@gmail.com> * Add minimessages coloring to head drops. --------- Signed-off-by: vLuckyyy <vluckyyy.biznes@gmail.com>

GH-233 Fix pearl cooldown (#233)

7a152e0

* Fix pearl cooldown Signed-off-by: vLuckyyy <vluckyyy.biznes@gmail.com> * Fix cooldown. --------- Signed-off-by: vLuckyyy <vluckyyy.biznes@gmail.com>

Migrate renovate config.

4c30b7d

dependency: Update dependency com.github.angeschossen:LandsAPI to v7.…

861aad1

…15.20 (#234) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

dependency: Update dependency com.github.ben-manes.caffeine:caffeine …

b9c625c

…to v3.2.1 (#235) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

dependency: Update dependency com.gradleup.shadow:com.gradleup.shadow…

40cac29

….gradle.plugin to v8.3.8 (#236) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Release v2.1.1

690678c

Merge branch 'master' into v2.0/angelchest-compat

75cc94f

# Conflicts: # eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java

merge conflicts

d2a9821

Jakubk15 closed this Aug 12, 2025

Jakubk15 deleted the v2.0/angelchest-compat branch August 12, 2025 05:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

GH-201 Disable drop feature entirely if dropType is unchanged #203

GH-201 Disable drop feature entirely if dropType is unchanged #203

Uh oh!

Jakubk15 commented Feb 8, 2025

Uh oh!

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

igoyek left a comment

Uh oh!

CitralFlo left a comment

Uh oh!

Rollczi left a comment

Uh oh!

Jakubk15 commented Feb 15, 2025

Uh oh!

Jakubk15 commented Mar 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

GH-201 Disable drop feature entirely if dropType is unchanged #203

GH-201 Disable drop feature entirely if dropType is unchanged #203

Uh oh!

Conversation

Jakubk15 commented Feb 8, 2025

Uh oh!

coderabbitai bot commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

igoyek left a comment

Choose a reason for hiding this comment

Uh oh!

CitralFlo left a comment

Choose a reason for hiding this comment

Uh oh!

Rollczi left a comment

Choose a reason for hiding this comment

Uh oh!

Jakubk15 commented Feb 15, 2025

Uh oh!

Jakubk15 commented Mar 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)