Skip to content

Night Shift: fix timeout memory leaks in dashboard #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EtanHey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Night Shift: fix timeout memory leaks in dashboard #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions src/routes/_authed/dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { convexQuery, useConvexMutation } from "@convex-dev/react-query";
import { api } from "@convex/_generated/api";
import { authClient } from "../../lib/auth-client";
import { Button } from "../../components/ui/button";
import { useState, useCallback, useMemo, useEffect } from "react";
import { useState, useCallback, useMemo, useEffect, useRef } from "react";
import type { Id } from "@convex/_generated/dataModel";
import WordDetailsModal from "../../components/WordDetailsModal";
import { getLanguageFlagString } from "../../components/LanguageFlag";
Expand Down Expand Up @@ -129,9 +129,10 @@ function DashboardPage() {
setMigrationChecked(true);
if (shouldShowMigrationModal(session.user.id)) {
// Small delay to let dashboard render first
setTimeout(() => {
const timer = setTimeout(() => {
setIsMigrationModalOpen(true);
}, 500);
return () => clearTimeout(timer);
Copy link

@cursor cursor bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration timer cleared before it can fire

Medium Severity

The cleanup returned from the migration useEffect clears the setTimeout created for opening the modal, but the same effect also calls setMigrationChecked(true). That state change re-runs the effect immediately, so the previous cleanup runs and cancels the timer in dashboard.tsx before setIsMigrationModalOpen(true) executes.

Additional Locations (2)

Fix in Cursor Fix in Web

}
}
}, [session?.user?.id, migrationChecked]);
Expand Down Expand Up @@ -182,19 +183,35 @@ function DashboardPage() {
const reorderWishlistMutation = useConvexMutation(api.wishlist.reorderWishlist);
const removeFromWishlistMutation = useConvexMutation(api.wishlist.removeFromWishlist);

// Initialize default goals mutation with error handling and retry
// Track retry state for goals initialization
const goalsRetryRef = useRef({ count: 0, timerId: null as ReturnType<typeof setTimeout> | null });

// Clean up any pending retry on unmount
useEffect(() => {
return () => {
if (goalsRetryRef.current.timerId) {
clearTimeout(goalsRetryRef.current.timerId);
}
};
}, []);

// Initialize default goals mutation with error handling and capped retry
const { mutate: initializeGoals } = useMutation({
mutationFn: (args: any) => initializeDefaultGoalsMutation(args),
onSuccess: () => {
goalsRetryRef.current.count = 0;
refetchGoals();
},
onError: (error) => {
console.warn('Initialize goals failed:', error);
// Retry after a delay if authentication error
if (error.message?.includes('Authentication required')) {
setTimeout(() => {
// Retry up to 3 times with increasing delay if authentication error
if (error.message?.includes('Authentication required') && goalsRetryRef.current.count < 3) {
goalsRetryRef.current.count++;
const delay = 2000 * goalsRetryRef.current.count;
goalsRetryRef.current.timerId = setTimeout(() => {
goalsRetryRef.current.timerId = null;
initializeGoals({});
}, 2000);
}, delay);
}
},
});
Expand Down