Skip to content

Correction #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabriel-dehan wants to merge 1 commit into
base: solution
Choose a base branch
from
Open

Correction #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions Wagon-3/01-Mail-spotter/parsing_mail.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@

def parse_mail(mail)

jokes= { "gmail" => "you're an average but modern person", "lewagon" => "you're skilled and capable", "live" => "aren't you born before 1973 ?" }
jokes= { "gmail" => "you're an average but modern person", "lewagon" => "you're skilled and capable", "live" => "aren't you born before 1973 ?" }

if mail.match(/[\w.-]+@[\w.-]+\.com/)
if mail.match(/^[\w.-]+@[\w.-]+\.com$/)

user_name = mail.match(/[\w.-]+@/)
domain = mail.split("@").last.split(".").first
user_name = mail.match(/[\w.-]+@/)
domain = mail.split("@").last.split(".").first

if user_name.to_s.include?(".")
name = user_name.to_s.split(".").first
else
name = mail.split("@").first
end
if user_name.to_s.include?(".")
name = user_name.to_s.split(".").first
else
name = mail.split("@").first
end

if jokes.select{ |x, y| x.include?(domain) }
puts "Hohoh #{name.capitalize}, #{jokes[domain]}"
else
puts "Sorry, I don't know this domain name and can't tell you any joke..."
end
if jokes.select{ |x, y| x.include?(domain) }
puts "Hohoh #{name.capitalize}, #{jokes[domain]}"
else
puts "Sorry, I don't know this domain name and can't tell you any joke..."
end

else
puts "Did you check your email address ?"
else
puts "Did you check your email address ?"
end

end

parse_mail("boris.coucou@lewagon.com") # => "Well done boris, you're skilled and capable"
parse_mail("boris.coucou@lewagon.com@gmail.com") # => "Well done boris, you're skilled and capable"