Fix _transitionEnd method to return early if _map is not defined#245
Open
JingWTG wants to merge 1 commit intoEsri:masterfrom
Open
Fix _transitionEnd method to return early if _map is not defined#245JingWTG wants to merge 1 commit intoEsri:masterfrom
JingWTG wants to merge 1 commit intoEsri:masterfrom
Conversation
Contributor
|
Hi, thank you for the PR. Are you able to post a public replication case to demonstrate the issue you're fixing? https://jsbin.com/jexevoy/edit?html,output |
Contributor
Author
Hi, I couldn’t reproduce it — the error came from our error reporting system. |
Contributor
Author
|
Message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our app encountered an error where
this._mapwas undefined when the callback function in_transitionEnd()was executed. SinceUtil.requestAnimFrame()is an asynchronous operation, the map reference can become undefined by the time the callback runs (e.g., if the layer is removed from the map before the animation frame is processed).