Hbase 14921 v3 - please review the recent addition of the CellFlatMap to CompactingMemStore#6
Open
sanastas wants to merge 9 commits intoHBASE-14920from
Open
Hbase 14921 v3 - please review the recent addition of the CellFlatMap to CompactingMemStore#6sanastas wants to merge 9 commits intoHBASE-14920from
sanastas wants to merge 9 commits intoHBASE-14920from
Conversation
Signed-off-by: anastas <anastas@yahoo-inc.com>
| } | ||
|
|
||
| @Override | ||
| protected Cell getCellFromIndex(int i) { |
There was a problem hiding this comment.
Didn't we just want to call it getCell()?
Collaborator
Author
There was a problem hiding this comment.
Fixed to getCell()
| private AtomicLong reusedChunkCount = new AtomicLong(); | ||
| private AtomicInteger chunkIDs = new AtomicInteger(1); // 14921 | ||
|
|
||
| // 14921: IDs Mapping of all chunks (key 0 is forbidden) |
There was a problem hiding this comment.
Please add comments and remove the jira number
| this.pipeline = new CompactionPipeline(getRegionServices()); | ||
| this.compactor = new MemStoreCompactor(); | ||
| initFlushSizeLowerBound(conf); | ||
| int t = conf.getInt(COMPACTING_MEMSTORE_TYPE_KEY, COMPACTING_MEMSTORE_TYPE_DEFAULT); |
Collaborator
Author
There was a problem hiding this comment.
Can you suggest something more meaningful then COMPACTING_MEMSTORE_TYPE ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Eshcar @ebortnik
As you know the code is not yet finished, but I would like to here your comments on the current state...