Merged
Conversation
added 5 commits
March 2, 2026 14:23
…nction api small number of layers
…--> layers.py, changed get attr module order if-else, isort
Closed
danibcorr
reviewed
Mar 6, 2026
danibcorr
reviewed
Mar 6, 2026
danibcorr
reviewed
Mar 6, 2026
Collaborator
There was a problem hiding this comment.
Is it possible to adjust the image resolution so that it is at the edge of the content?
danibcorr
reviewed
Mar 6, 2026
Collaborator
There was a problem hiding this comment.
Is it possible to adjust the image resolution so that it is at the edge of the content?
danibcorr
reviewed
Mar 11, 2026
danibcorr
reviewed
Mar 11, 2026
danibcorr
reviewed
Mar 11, 2026
illia/layers.py
Outdated
|
|
||
|
|
||
| # Non-parametric layers by category | ||
| _POOLING_LAYERS: Final[frozenset[str]] = frozenset( |
Collaborator
There was a problem hiding this comment.
This is something that maybe we can discuss, but we could use Final[tuple[str, ...] as typing instead of frozenset. Also, maybe we need to find a way of creating this layers configuration dynamically and not hardcoded.
danibcorr
reviewed
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.