Skip to content

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Jul 7, 2025

Created a ci job (small_test), to run the codechecker Bazel rule on a tiny Bazel project (yaml-cpp)

The installation of static analyzers and CodeChecker, and such have been moved to actions/env_setup/action.yml, to avoid repeating code.

- name: Run Bazel CodeChecker
run: |
cd yaml-cpp
bazel build :codechecker_test_yaml-cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should likely use bazel test. Also, we added two new targets, codechecker_test_yaml-cpp and code_checker_test_yaml-cpp, but are only testing the former.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running it with bazel test produces errors (despite filling the log with the success message of CodeChecker), thats why I have been using bazel build.

Copy link
Collaborator

@nettle nettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach! But I think this project (yaml-cpp) should not be the only one. I would suggest adding this project as one-of-many, like putting files into sub directories with patches and test launchers etc

@furtib furtib requested a review from Szelethus July 9, 2025 08:04
- name: Run Monolithic Bazel CodeChecker
run: |
cd test_project
bazel build :codechecker_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its still okay to call bazel test here, just negate the return value. Preferably also add a coment as to why the return value needs negating (because there are findings by CodeChecker).

@furtib furtib requested a review from Szelethus July 9, 2025 11:59
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change "small project" to the name of the project consistently, as we will add more than one project. Otherwise LGTM!

nettle
nettle previously requested changes Jul 21, 2025
Copy link
Collaborator

@nettle nettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach! But I think this project (yaml-cpp) should not be the only one. I would suggest adding this project as one-of-many, like putting files into sub directories with patches and test launchers etc

@furtib furtib force-pushed the ci_test_project branch 8 times, most recently from 6d23639 to e9dde24 Compare July 23, 2025 07:03
@nettle
Copy link
Collaborator

nettle commented Jul 25, 2025

Let's agree on the structure first, see #22

@furtib furtib force-pushed the ci_test_project branch 2 times, most recently from 2962a92 to 03ac739 Compare July 31, 2025 05:53
@furtib
Copy link
Contributor Author

furtib commented Jul 31, 2025

Changed to the structure we agreed on in: #22

The composite action file's name must be action.yml; it can't be changed!
The name of the folder in actions has to describe what the action.yml file does!
See Note on top of this page:
https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax

@furtib furtib force-pushed the ci_test_project branch 2 times, most recently from b2d5bab to 2a29b1b Compare July 31, 2025 06:03
@furtib furtib requested a review from nettle July 31, 2025 08:14
@furtib furtib requested a review from Szelethus August 1, 2025 09:07
@furtib
Copy link
Contributor Author

furtib commented Aug 4, 2025

This PR is getting too big, so I'm leaving it here as a template.

@furtib furtib marked this pull request as draft August 4, 2025 06:26
@nettle nettle dismissed their stale review August 6, 2025 14:22

Please disregard the request to change

@furtib furtib self-assigned this Aug 11, 2025
@furtib
Copy link
Contributor Author

furtib commented Sep 3, 2025

Superseeded by #43 #72 #73

@furtib furtib closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants