Use python toolchain instead of python runtime #146
+35
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Need to make python runtime more portable and be ready for rules_python support. What: - Add toolchain for python instead of _python_runtime - Add portable functions for python - Fix register_toolchains
furtib
requested changes
Jan 21, 2026
| ) | ||
|
|
||
| register_default_python_toolchain() | ||
| register_toolchains("@default_python_tools//:python_toolchain") |
Contributor
There was a problem hiding this comment.
This line must be added to test/foss/templates/WORKSPACE.template too!
Without this, all FOSS tests using the WORKSPACE file will fail.
Tested locally, all tests are passing with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Need to make python runtime more portable
and be ready for rules_python support.
What:
Addresses:
First step for rules_python support (Bazel 8) #108