Fix jenkins testing #143
Open
Fix jenkins testing #143
+95
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szelethus
reviewed
Jan 16, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Are both the .bazelrc and the test changes required?
Contributor
Author
|
This is the only test where, no matter what we place in the |
furtib
force-pushed
the
fix-jenkins
branch
2 times, most recently
from
986e1c0 to
fe3b08f
Compare
nettle
requested changes
Jan 16, 2026
.bazelrc
Outdated
| @@ -0,0 +1 @@ | |||
| test --experimental_cc_implementation_deps | |||
Collaborator
There was a problem hiding this comment.
Can we avoid adding .bazelrc ?
Is it possible to add --experimental_cc_implementation_deps only to tests which test implementation_deps?
Contributor
Author
There was a problem hiding this comment.
It seems like adding a manual tag to the cc_* targets themselves is enough to circumvent the use of the flag.
I have removed the .bazelrc file
Szelethus
reviewed
Jan 21, 2026
furtib
force-pushed
the
fix-jenkins
branch
3 times, most recently
from
d199e8a to
57add31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
We want the jenkins test's to pass
What:
cc_*,compile_commands,codechecker_testtargets (all of these are necessary for bazel test ... to pass)--enable_bzlmodflag, so I re-added the WORKSPACE file for the test.Addresses:
Fixes: #123