Create a convenience function for interacting with compile_commands_impl #141
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szelethus
added
the
non-functional change ☮️
Szelethus
force-pushed
the
refactor_comp_comm_impl_usage
branch
from
74b2e55 to
4c0e4cc
Compare
nettle
requested changes
Jan 15, 2026
Collaborator
nettle
left a comment
nettle
left a comment
There was a problem hiding this comment.
To be honest I'm kind of against this change.
May we discuss this before submitting?
Contributor
Author
|
Yes, sure, can you explain what about this change you think is troublesome? Is this a concern about an external factor, or is the patch incorrect? |
Collaborator
|
Hi @Szelethus, |
Szelethus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
In anticipation of #98, where we remove the compilation database generation from per_file analysis and reuse compile_commands.bzl, we identified that the best point of entry might not be
compile_commands_impl(), because we still need to check and parse the return values. Since we need the exact same ~20 lines of code that codechecker.bzl already uses, lets just turn that into a convenience function.What:
Turn the handling/parsing of compile_commands_impl into a function.
Addresses:
Accessory to #98.