Add cuda-{dynamic,static} to allow static-linking for cudarc#11
Merged
EricLBuehler merged 3 commits intoEricLBuehler:masterfrom Feb 3, 2026
Merged
Add cuda-{dynamic,static} to allow static-linking for cudarc#11EricLBuehler merged 3 commits intoEricLBuehler:masterfrom
cuda-{dynamic,static} to allow static-linking for cudarc#11EricLBuehler merged 3 commits intoEricLBuehler:masterfrom
Conversation
`cudarc` sets the feature `dynamic-linking` by default, but instead this PR adds the features `cuda-dynamic` and `cuda-static` so that the `cuda` in `float8` still defaults to `dynamic-linking`, but still offering the possibility to use `cuda-static` with `static-linking`
EricLBuehler
approved these changes
Feb 3, 2026
Owner
EricLBuehler
left a comment
EricLBuehler
left a comment
There was a problem hiding this comment.
👍
cuda-dynamic and cuda-static are already checked to be mutually exclusive:
https://github.com/chelsea0x3b/cudarc/blob/003498c180495f78152241ac893931529e13d1a5/build.rs#L62-L63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the features
cuda-dynamicandcuda-staticso that thedynamic-linkingis not enforced when installingcudarcbut rather moved undercuda-dynamicwithdynamic-linkingandcuda-staticwithstatic-linking. Additionally, thecudafeature is left as-is, meaning it defaults tocuda-dynamic.Finally, this PR also bumps the
float8version to 0.6.1; and also excludesconstsfromtyposas otherwise it leads to the CI to fail.