Skip to content

FP8 alloc and zero impl #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guoqingbao wants to merge 1 commit into
base: dev_main
Choose a base branch
from
Open

FP8 alloc and zero impl #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions candle-core/src/cuda_backend/device.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
use super::{CudaError, CudaStorage, CudaStorageSlice, WrapErr};
use crate::backend::{BackendDevice, BackendStorage};
use crate::{CpuStorage, CpuStorageRef, DType, Layout, Result, Shape};
pub use candle_kernels as kernels;
pub use cudarc;
use cudarc::driver::CudaFunction;
use float8::F8E4M3;
use half::{bf16, f16};
use std::collections::HashMap;
use std::sync::{Arc, Mutex, RwLock};

use super::{CudaError, CudaStorage, CudaStorageSlice, WrapErr};

/// Unique identifier for cuda devices.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
pub struct DeviceId(usize);
Expand Down Expand Up @@ -359,7 +359,9 @@ impl BackendDevice for CudaDevice {
CudaStorageSlice::F64(data)
}
DType::F8E4M3 => {
return Err(CudaError::InternalError("F8E4M3 not supported in CUDA backend").into())
let data = self.alloc_zeros::<F8E4M3>(elem_count)?;
CudaStorageSlice::F8E4M3(data)
// return Err(CudaError::InternalError("F8E4M3 not supported in CUDA backend").into())
}
DType::F6E2M3 | DType::F6E3M2 | DType::F4 | DType::F8E8M0 => {
return Err(
Expand Down Expand Up @@ -512,7 +514,9 @@ impl BackendDevice for CudaDevice {
CudaStorageSlice::F64(data)
}
DType::F8E4M3 => {
return Err(CudaError::InternalError("F8E4M3 not supported in CUDA backend").into())
let data = self.alloc::<F8E4M3>(elem_count)?;
CudaStorageSlice::F8E4M3(data)
// return Err(CudaError::InternalError("F8E4M3 not supported in CUDA backend").into())
}
DType::F6E2M3 | DType::F6E3M2 | DType::F4 | DType::F8E8M0 => {
return Err(
Expand Down
Loading