iOS Support for Metal Backend#91
Closed
OptimusLime wants to merge 7 commits intoEricLBuehler:dev_mainfrom
atelico:dev_main
Closed
iOS Support for Metal Backend#91OptimusLime wants to merge 7 commits intoEricLBuehler:dev_mainfrom atelico:dev_main
OptimusLime wants to merge 7 commits intoEricLBuehler:dev_mainfrom
atelico:dev_main
Conversation
…ation (see [issue on Candle main](huggingface#2322)) 1. Replaced references to MTLResourceOptions::StorageMode* enums to METAL_SHARED_BUFFER_STORAGE_MODE Tested working on iOS 18.2 iphone14 pro and iphone 16 pro.
…-issues-stricter-on-ios)
Author
|
The errors are much more subtle on iOS than expected, I am going to close for now and re-open later for review when I'm closer to having the answer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to crashes during either new_metal device calls or resource allocation (see issue on Candle main)
Tested working on iOS 18.2 iphone 16 pro and M4 iPad Pro