Proposal: Respect the gamerule announceAdvancement#10
Open
Wolfdv1 wants to merge 1 commit intoErdbeerbaerLP:1.21.3from
Open
Proposal: Respect the gamerule announceAdvancement#10Wolfdv1 wants to merge 1 commit intoErdbeerbaerLP:1.21.3from
Wolfdv1 wants to merge 1 commit intoErdbeerbaerLP:1.21.3from
Conversation
Author
|
tested and working for Fabric with this branch in 1.21.4: advancement-QOL-test-1.21.4 (updated deps to 1.21.4 for testing, working in production on my server atm) with another feature enabled: advancement-channel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing this check to be added as noticed that when using https://modrinth.com/datapack/blazeandcaves-advancements-pack as it has config to set different tiers of Advancements to display or not- it does not actually set the advancements themselves to not display but rather toggles and toggles GameRules.RULE_ANNOUNCE_ADVANCEMENTS to do this dynamically.
Just a small change, if you think it may be beneficial to only do this under a config toggle then let me know.
The result in this is lots of Advancements (basic tasks and alike) that have been set to not announce do not announce in the gamechat, but they do all get announced in discord.
having build issues, and unable to test with the latest 1.21.4 release as cannot find in VCS, if there are particular Gradle tasks for testing that I should run please feel free to inform me :)