Add support for #RRGGBB hex colour values for embed#203
Open
Wolfdv1 wants to merge 1 commit intoErdbeerbaerLP:masterfrom
Open
Add support for #RRGGBB hex colour values for embed#203Wolfdv1 wants to merge 1 commit intoErdbeerbaerLP:masterfrom
Wolfdv1 wants to merge 1 commit intoErdbeerbaerLP:masterfrom
Conversation
The [embed creator](https://embed.dan.onl/) I initially used gave hex rather than the decimal representation, this function checks against a quick regex to see if #RRGGBB hex value has been used and if so converts it to decimal and returns the string as normal. Example: ```jsonColorHexToDec("{\r\n \"author\": {\r\n \"name\": \"%name%\",\r\n \"icon_url\": \"https://crafthead.net/avatar/%uuid%\"\r\n },\r\n \"description\": \"%msg%\",\r\n \"color\": \"#4F545C\"\r\n}") gives: ```{\r\n \"author\": {\r\n \"name\": \"%name%\",\r\n \"icon_url\": \"https://crafthead.net/avatar/%uuid%\"\r\n },\r\n \"description\": \"%msg%\",\r\n \"color\": \"5198940\"\r\n} And if decimal is given originally, no changes are made ##### ps, the function itself is tested standalone- has not been integration tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embed creator I initially used gave hex rather than the decimal representation, this function checks against a quick regex to see if #RRGGBB hex value has been used and if so converts it to decimal and returns the string as normal.
Example:
gives:
And if decimal is given originally, no changes are made.
Currently if a Hex value #RRGGBB is given the following crash error is given:
The above function would prevent this, and also may be altered for formats of 0xRRGGBB along with #RRGGBB as needed.
ps, the function itself is tested standalone- but has not been integration tested