Fix combined search null references to recordTotal#15
Open
maccabeelevine wants to merge 1 commit intoEquinoxOpenLibraryInitiative:mainfrom
Open
Fix combined search null references to recordTotal#15maccabeelevine wants to merge 1 commit intoEquinoxOpenLibraryInitiative:mainfrom
maccabeelevine wants to merge 1 commit intoEquinoxOpenLibraryInitiative:mainfrom
Conversation
maccabeelevine
commented
Sep 7, 2023
| if (isset($this->parseError)): | ||
| $headTitleText = $this->transEsc('nohit_parse_error'); | ||
| elseif ($recordTotal < 1): | ||
| elseif ($this->results->getResultTotal() < 1): |
Author
There was a problem hiding this comment.
This reference to $recordTotal generated the error.
maccabeelevine
commented
Sep 7, 2023
| '%%start%%' => $this->localizedNumber($this->results->getStartRecord()), | ||
| '%%end%%' => $this->localizedNumber($this->results->getEndRecord()), | ||
| '%%total%%' => $this->localizedNumber($this->recordTotal), | ||
| '%%total%%' => $this->localizedNumber($this->results->getResultTotal()), |
Author
There was a problem hiding this comment.
I never hit an error here (not sure the code path) but it seemed best to change in both places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice theme! Testing combined search, I got a null reference error for $recordTotal. In other template files in your theme and others, this variable was set from $this->results->getResultTotal().