Conversation
…idation path - Added dedicated IWalletAggregator interface and wired PQCWallet.validateUserOp to invoke it whenever on-chain verification is disabled, bypassing signature- length gate. - Introduced mock aggregator that reverts on validateUserOp calls to clearly signal aggregator path during testing. - Created deterministic tests verifying that forceOnChainVerify disables aggregator usage, while disabling the flag returns the aggregator sentinel and triggers the mock’s revert. - Defined minimal IWalletAggregator interface to support compilation and future integrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a dedicated IWalletAggregator interface and wires the
PQCWallet validation flow to support optional aggregator-based signature
verification. It also adds a mock aggregator and deterministic tests to ensure
the forceOnChainVerify flag behaves as intended.
Changes
verification is disabled, bypassing the signature-length gate.
aggregator path usage in tests.
Motivation
This work provides a clean contract interface for aggregators and lays the
groundwork for future integrations, while ensuring deterministic control
through the forceOnChainVerify flag. The mock aggregator and tests provide
strong guardrails around path selection.
Testing
forge buildforge test -vvChecklist