Conversation
… and docs - Introduced authoritative commons library clarifying canonical digest choice, aggregator attestation structure, and atomic key rotation with nonce tied to WOTS index. - Hardened wallet with explicit signature-length constants, documented byte offsets, and renamed on-chain verification event to ForceOnChainVerifySet. - Added signature-layout guardrail test to enforce 4417-byte format and offset calculations. - Documented canonical digest semantics and signature packing order in README for clearer developer guidance.
- Replaced the deprecated withOpacity call with withValues(alpha: 0.1) in the activity feed status badge to align with updated Flutter APIs and prevent analyzer failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an authoritative commons library for digest semantics and
attestation structure, hardens wallet signature handling with explicit constants
and renamed events, and adds guardrail tests to lock in the canonical 4417-byte
signature layout. Documentation has been updated to clearly define digest
semantics and signature packing order.
Changes
attestation structure, and atomic key rotation with nonce tied to WOTS index.
ForceOnChainVerifySet.and offset calculations.
for developer clarity.
Motivation
These updates provide a single source of truth for digest and attestation logic,
make wallet signature handling more robust, and ensure future changes cannot
break the canonical hybrid signature format. Developer guidance is now clearer
and easier to follow.
Testing
forge build --sizesforge test -vvgrep -R "ForceOnChainSet" -n .Checklist