Conversation
- Add `abi/PQCWallet.json` containing full ABI for PQCWallet contract - Expand PQCWallet contract with NatSpec docs, events, and helper methods: - Document constructor, `validateUserOp`, `execute`, `executeBatch`, and ETH handling - Add `depositToEntryPoint()` and explicit payable `receive()` - Emit `WOTSCommitmentsUpdated` on rotation and staging - Introduce `contracts/constants/EntryPoint.sol` with canonical Base mainnet & Sepolia addresses - Update `Deploy.s.sol` to: - Import canonical EntryPoint addresses - Select correct address based on `chainid` (8453 = mainnet, 84532 = sepolia) - Remove placeholder constant, revert on unsupported chains - Deploy PQCWallet with demo WOTS key commitments and log deployed address Rationale: ensures ABI availability for clients, locks in EntryPoint addresses, adds clearer wallet lifecycle documentation, and makes deployment scripts chain-aware for both testing and production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the ABI and constants for the PQCWallet contract, improves documentation and helper functions within the wallet, and updates the deployment script to automatically resolve the correct EntryPoint address for Base networks.
Changes
smart-contracts/abi/PQCWallet.jsonwith the complete ABI for the PQCWallet.depositToEntryPoint()to fund the EntryPoint directly.receive()function for plain ETH transfers.WOTSCommitmentsUpdatedconsistently on rotation and staging of new WOTS keys.contracts/constants/EntryPoint.solwith canonical EntryPoint addresses for Base Mainnet and Base Sepolia.Deploy.s.solto import canonical addresses.chainid(8453 = Base Mainnet, 84532 = Base Sepolia).Motivation
This update provides clients and integration tooling with a canonical ABI, locks EntryPoint addresses into constants for reproducibility, and eliminates manual intervention during deployment. The documentation improvements clarify contract usage, while helper functions improve UX for funding and operation.
Testing
Checklist