Conversation
- Added `docs/dev/branching.md` documenting Git Flow workflow and versioning - Updated `.github/PULL_REQUEST_TEMPLATE.md` with a contributor checklist: - tests added/updated - docs updated - lint checks pass
- Added `.github/workflows/ci.yml` to run: - smart-contracts: setup Foundry, `forge build`, `forge test -vv` - mobile: setup Flutter, `flutter analyze`, `flutter test` - mobile/crypto/mnemonic.dart: - Use `Uint8List.fromList(seed)` for BIP32 - Remove unused u8 helper; tidy imports - mobile/main.dart: - Use `ContractFunction` ABI encoding for `execute(...)` - Parse ETH amounts via `EtherAmount.fromBase10String` - Build `MsgSignature` from `signToUint8List(...)` - Encode `getUserOpHash` with typed ABI (TupleType) instead of manual bytes - Minor UI formatting & status messaging - mobile/userop/userop_signer.dart: - Pack ECDSA r/s with 32-byte left-pad; use `w3.MsgSignature` - Add `hkdfIndex` helper; small keccak/hex utils cleanup - mobile/theme/theme.dart: - Minor theming/layout formatting and border config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a CI pipeline for both contracts and mobile, fixes ABI/signature handling in the Flutter client, and extends contributor documentation with branching strategy and a PR checklist.
Changes
.github/workflows/ci.yml:forge build,forge test -vvflutter analyze,flutter testmnemonic.dart: fixed BIP32 seed handling usingUint8List.fromList.main.dart:execute(address,uint256,bytes).EtherAmount.fromBase10String.MsgSignaturefromsignToUint8List.getUserOpHash.userop_signer.dart:w3.MsgSignature; addedhkdfIndexhelper.theme.dart: formatting and input border tweaks.docs/dev/branching.md:main,develop,feature/*,release/*).v0.1.0..github/PULL_REQUEST_TEMPLATE.md:Motivation
Testing
forge build && forge test -vvflutter analyze && flutter testdocs/dev/branching.mdis included in the repo structure.