Fix keybindings config merging#46
Merged
nicholasjpaterno merged 1 commit intoEpistates:mainfrom Mar 4, 2026
Merged
Conversation
enzalito
force-pushed
the
fix-keybindings
branch
from
9cd4b78 to
22ca3cb
Compare
enzalito
force-pushed
the
fix-keybindings
branch
from
22ca3cb to
fd83079
Compare
Contributor
|
@enzalito thanks for the PRs! Your rust is just fine. I'm taking a look now at both of your PRs - contributions are greatly appreciated! I hope you're otherwise enjoying |
Contributor
|
@enzalito there are a few minor tweaks that I will make but for the most part these look great! Thank you for taking the time to open these. |
Contributor
Author
|
Thanks! It's a really nice tool. Looking forward to making some more contributions in the future! |
Contributor
|
Thank you @enzalito that would be greatly appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently user keybindings are not properly merged, the defaults take precedence on the user defined ones.
This PR fixes that and also adds a
Noopaction to allow keys to be unbound.The
keybindingscrate stores binds in aVecand does not filter out duplicate key sequences so i added de-duplication logic toKeybindings::from_config. That way functions that iterate on the bindings (likeKeybindings::help_entries) will work as expected.I'm pretty new to Rust so sorry in advance if my code stinks.