Fix Onboarding page got wiped out#38
Open
keegang6705 wants to merge 2 commits intoEpicGazel:masterfrom
Open
Conversation
…t only emoji picker upsell, not onboarding page
keegang6705
changed the title
|
Maybe just |
Author
maybe make it less strict is a good idea too 🤔 since discord update might break this |
tested this not removing onboarding page
Owner
|
@keegang6705 Can you provide some examples of pages where you see the upsell/promotions? The only place I see one is in the soundboard right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Onboarding page got wipe out by make it selecting with more strictly selector