Add guard against closed peerConnection#788
Open
FloEdelmann wants to merge 2 commits intoEpicGamesExt:masterfrom
Open
Add guard against closed peerConnection#788FloEdelmann wants to merge 2 commits intoEpicGamesExt:masterfrom
FloEdelmann wants to merge 2 commits intoEpicGamesExt:masterfrom
Conversation
🦋 Changeset detectedLatest commit: f148e87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Similar to #719: Fix for throwing error when
peerConnectionis not defined. We see some events in Sentry wherepeerConnectionhas been available at the start of the function, but not anymore in thethencallback; the connection must have been closed in the meantime.Solution
Currently when
peerConnectionis not defined, the rest of the function is not executed because an error is thrown (null is not an object (evaluating 'this.peerConnection.getReceivers')). Now the error is silenced and the return statement still prevents further execution.Documentation
N/A
Test Plan and Compatibility
There are no code behavior changes, apart from no error being thrown anymore. The error previously was unhandled because
generateStatswas called in a window interval (viaWebRtcPlayerController.getStats).