feat: Run application using docker compose#12
Open
ForeverRainmaN wants to merge 1 commit intoEpamLifeSciencesTeam:mainfrom
Open
feat: Run application using docker compose#12ForeverRainmaN wants to merge 1 commit intoEpamLifeSciencesTeam:mainfrom
ForeverRainmaN wants to merge 1 commit intoEpamLifeSciencesTeam:mainfrom
Conversation
ForeverRainmaN
requested review from
Dmitrii-Shevchenko,
GrigoriiBerezin and
myazinn
ForeverRainmaN
force-pushed
the
EPMLSTRCMW-Run-Application-Using-Docker-Compose
branch
2 times, most recently
from
5ba4575 to
e33b1a2
Compare
ForeverRainmaN
force-pushed
the
EPMLSTRCMW-Run-Application-Using-Docker-Compose
branch
from
e33b1a2 to
02e6470
Compare
Comment on lines
+5
to
9
| url = "jdbc:postgresql://"${RANDOM_COFFEE_DB_SERVER_NAME}":5432/coffee_db?currentSchema=authentication" | ||
| user = "postgres" | ||
| user = ${?AUTH_DB_USER} | ||
| user = "postgres" | ||
| password = "postgres" | ||
| password = "postgres" |
There was a problem hiding this comment.
I think you should use parameters from an additional env or conf file with {SOME_PARAMETER}. Because if you create a dev or prod pipeline, you can use ansible or something else to create that.
GrigoriiBerezin
requested changes
Apr 6, 2022
Collaborator
GrigoriiBerezin
left a comment
GrigoriiBerezin
left a comment
There was a problem hiding this comment.
Great job, but some things could be improved.
Also don't forget about checking, that every file contains newline at the EOF
| @@ -0,0 +1,7 @@ | |||
| #!/bin/bash | |||
| set -e | |||
| psql -v ON_ERROR_STOP=1 --username "postgres" --dbname "coffee_db" <<-EOSQL | |||
Collaborator
There was a problem hiding this comment.
You've forgot about making username and dbname come from envs
Comment on lines
+1
to
+10
| COFFEE_CONTAINER_PATH=/random_coffee/app | ||
| COFFEE_CONTAINER_NAME=random_coffee | ||
| COFFEE_CONTAINER_LOGS=/random_coffee/app/logs | ||
| COFFEE_CONTAINER_PORT=8080 | ||
| COFFEE_DB_HOST=postgres | ||
| COFFEE_DB_PORT_NUMBER=5432 | ||
| COFFEE_DB_NAME=coffee_postgres_db | ||
| COFFEE_DB_USER=postgres | ||
| COFFEE_DB_PASSWORD=postgres | ||
| COFFEE_DB_CONTAINER_NAME=coffee_postgres No newline at end of file |
Collaborator
There was a problem hiding this comment.
If you will leave env example, please make sure, that it does not contain any sensitive data such as username and passwords, replace it with dummy values
DruzhininPavel
requested changes
Apr 7, 2022
| ``` | ||
| After image is created, run: | ||
| ``` | ||
| docker compose up / docker compose up -d (if you wan't compose to run in detached mode) |
There was a problem hiding this comment.
docker-compose NOT docker compose
PatokovN
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.