Skip to content

Comments

Add improved ts support#18

Open
yoav0gal wants to merge 2 commits intoEomm:mainfrom
yoav0gal:main
Open

Add improved ts support#18
yoav0gal wants to merge 2 commits intoEomm:mainfrom
yoav0gal:main

Conversation

@yoav0gal
Copy link

@yoav0gal yoav0gal commented Jan 9, 2024

Used Database from @types/sqlite3 insted of sqlite.
Based of @yukha-dw great work

@Eomm , don't forget to republish to npm when approving!

published to npm for now link

@yukha-dw yukha-dw mentioned this pull request Jan 10, 2024
@yoav0gal
Copy link
Author

TBH, I don't think I did the types well,
The use sqlite3.open or sqlite.Database based on promiseAPI=true is very confusing.
Created my own version for our needs (powered by sqlite3 only) because my work space is in a hurry.
Fell free to use/migrate fastify-sqlite-typed.

Copy link
Owner

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree that the API could be confusing, it was a missing module and I did not get time to shape it correctly.

I will rewrite it bottom-down in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants