Skip to content

More cleanup to 1.12 cconv#3031

Merged
wsmoses merged 1 commit intomainfrom
ccfix
Mar 29, 2026
Merged

More cleanup to 1.12 cconv#3031
wsmoses merged 1 commit intomainfrom
ccfix

Conversation

@wsmoses
Copy link
Copy Markdown
Member

@wsmoses wsmoses commented Mar 29, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/typeutils/jltypes.jl b/src/typeutils/jltypes.jl
index a44c380e..73364534 100644
--- a/src/typeutils/jltypes.jl
+++ b/src/typeutils/jltypes.jl
@@ -160,7 +160,8 @@ function handle_param(args, codegen_types, @nospecialize(source_typ::Type), @nos
             rooted_arg_i = rooted_typ === nothing ? nothing : (source_i - 1),
             rooted_cc = rooted_typ === nothing ? nothing : last_cc,
             arg_jl_i = arg_jl_i,
-        ))
+            )
+        )
         last_cc = GPUCompiler.GHOST
         return (orig_i, codegen_i, last_cc)
     end
@@ -171,7 +172,8 @@ function handle_param(args, codegen_types, @nospecialize(source_typ::Type), @nos
 			rooted_arg_i = rooted_typ === nothing ? nothing : (source_i - 1),
             rooted_cc = rooted_typ === nothing ? nothing : last_cc,
 			arg_jl_i = arg_jl_i,
-        ))
+            )
+        )
         orig_i += 1
 	    last_cc = RemovedParam
         return (orig_i, codegen_i, last_cc)
@@ -200,7 +202,7 @@ function handle_param(args, codegen_types, @nospecialize(source_typ::Type), @nos
             )
             # - boxed values
             #   XXX: use `deserves_retbox` instead?
-		    last_cc = GPUCompiler.BITS_VALUE
+            last_cc = GPUCompiler.BITS_VALUE
         elseif llvm_source_typ isa LLVM.PointerType
             if llvm_source_typ != codegen_typ
                 throw(AssertionError("Mismatch codegen type llvm_source_typ=$(string(llvm_source_typ)) codegen_typ=$(string(codegen_typ)) source_i=$source_i source_sig=$source_sig, source_typ=$source_typ, codegen_i=$codegen_i, codegen_types=$(string(codegen_ft))"))

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

Benchmark Results

main 8ccf031... main / 8ccf031...
basics/make_zero/namedtuple 0.054 ± 0.0026 μs 0.0528 ± 0.0028 μs 1.02 ± 0.072
basics/make_zero/struct 0.284 ± 0.0074 μs 0.267 ± 0.0058 μs 1.06 ± 0.036
basics/overhead 4.65 ± 0.01 ns 4.03 ± 0.001 ns 1.15 ± 0.0025
basics/remake_zero!/namedtuple 0.225 ± 0.022 μs 0.229 ± 0.023 μs 0.983 ± 0.14
basics/remake_zero!/struct 0.227 ± 0.0063 μs 0.231 ± 0.022 μs 0.985 ± 0.098
fold_broadcast/multidim_sum_bcast/1D 10.3 ± 0.24 μs 10.3 ± 0.41 μs 0.994 ± 0.046
fold_broadcast/multidim_sum_bcast/2D 12.1 ± 0.25 μs 12.2 ± 0.25 μs 0.999 ± 0.029
time_to_load 1.06 ± 0.02 s 1.05 ± 0.0046 s 1.01 ± 0.019

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/23718502825/artifacts/6168266949.

@wsmoses wsmoses merged commit 1ede68c into main Mar 29, 2026
55 of 69 checks passed
@wsmoses wsmoses deleted the ccfix branch March 29, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant