Fix type error, improve CI pipeline, and complete example coverage#24
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 15, 2026
Merged
Conversation
- Fix TS2339 type error in check-spec-schema-sync.ts with proper type assertion for allOf conditional array - Bump ajv 8.17.1->8.18.0 and @types/node 20.19.30->20.19.33 - Add spec/** path trigger to CI so spec changes run validation - Add tsc --noEmit, check:refs, and check:coverage to CI pipeline - Extract shared AJV utilities into scripts/lib/ajv-utils.ts to remove duplication between validate-schemas.ts and validate-examples.ts - Add annotations, asset-index, and provenance example files to achieve 15/15 schema coverage (was 12/15)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-spec-schema-sync.ts(lines 174-177) with proper type assertion for theallOfconditional array —tsc --noEmitnow passes cleanlyajv8.17.1 → 8.18.0 and@types/node20.19.30 → 20.19.33spec/**to CI path triggers so spec-only changes run validationtsc --noEmit,check:refs, andcheck:coveragesteps to CI pipelinecreateAjv,loadSchema) intoscripts/lib/ajv-utils.ts, removing duplication betweenvalidate-schemas.tsandvalidate-examples.tsTest plan
npx tsc --noEmitpasses with 0 errorsnpm testpasses — 16 schemas compiled, 44 examples validatednpm run check:sync— 65/65 types synchronizednpm run check:refs— 26/26 cross-references validnpm run check:coverage— 15/15 schemas covered, 8/8 extensions covered