Add extension attribute schema tests and CI feature matrix#94
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
Prevent field-level spec divergences with table-driven tests that verify field names and types for every ExtensionMark convenience constructor. Also adds a citation mark archive roundtrip test and a CI job that tests important feature combinations (no-features, zstd, signatures, etc.).
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdx-core/tests/extension_schema.rswith table-driven tests verifying field names and types for all 15ExtensionMarkconvenience constructors (citation, entity, glossary, index, equation_ref, algorithm_ref, theorem_ref, highlight, etc.)"refs"array and legacy"ref"string formats)Citationstruct schema tests verifying serialization emits"refs"(not"ref") and deserialization accepts bothCdxWriter/CdxReader)Test plan
cargo test --workspace --all-featurespasses (1052 tests, 0 failures)cargo clippy --workspace --all-features -- -D warningscleancargo build -p cdx-core --no-default-featuresbuilds successfully