Add spec conformance tests and housekeeping#88
Merged
gvonness-apolitical merged 4 commits intomainfrom Feb 16, 2026
Merged
Conversation
Include identity metadata (title, creator, subject, description, language) in document ID computation per spec §06 §4.1. Add 17 conformance tests covering hash boundary inclusion/exclusion properties and block type serialization for all 25 block variants.
Add 24 conformance tests covering Phase 1C-1H of the spec conformance matrix: manifest field validation (6), state machine enforcement (3), provenance/lineage chain properties (7), Dublin Core metadata requirements (2), signature structure validation (2), and extension declaration/validation (4).
Mark all Phase 1A-1H conformance tests as PASS and update test file references from tests/integration.rs to tests/conformance.rs. Remaining TODOs: 4 asset embedding (require file I/O), 4 property-based (stretch), 1 container format (ZIP ordering).
Document the rationale for all clippy::too_many_lines and missing_panics_doc suppressions. Update architecture.md to reflect the custom serde layer for spec-compliant wire format.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy::too_many_linesandmissing_panics_doclint suppressions with inline justificationsTest plan
cargo build --workspace --all-featurespassescargo test --workspace --all-featurespasses (1,014 tests)cargo clippy --workspace --all-features -- -D warningspasses (0 warnings)cargo fmt --all -- --checkpasses