Fix spec serialization divergences and add conformance tests#87
Merged
gvonness-apolitical merged 2 commits intomainfrom Feb 16, 2026
Merged
Fix spec serialization divergences and add conformance tests#87gvonness-apolitical merged 2 commits intomainfrom
gvonness-apolitical merged 2 commits intomainfrom
Conversation
Custom Serialize/Deserialize for Mark and Block enums to match
the Codex file format spec wire format:
- Rename Mark::Math { value } to { source }
- Simple marks serialize as strings ("bold") not objects
- Extension marks use colon-delimited type ("semantic:citation")
- Extension blocks use colon-delimited type ("academic:theorem")
- FigCaption serializes as "figcaption" (lowercase)
- block_type() returns Cow<str> with "namespace:blockType" for extensions
All old formats accepted on deserialization for backward compatibility.
Adds 22-test conformance suite to prevent future spec drift.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gvonness-apolitical
added a commit
that referenced
this pull request
Feb 16, 2026
The hand-written Serialize/Deserialize impls from PR #87 are the most complex recent addition. These fuzz targets exercise all type dispatch paths with arbitrary input to catch panics or unexpected behavior in the custom deserialization logic.
3 tasks
gvonness-apolitical
added a commit
that referenced
this pull request
Feb 16, 2026
The hand-written Serialize/Deserialize impls from PR #87 are the most complex recent addition. These fuzz targets exercise all type dispatch paths with arbitrary input to catch panics or unexpected behavior in the custom deserialization logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarkandBlockenums to match the Codex file format spec wire formatvalue→source), simple marks as strings, extension marks/blocks with colon-delimited types, figcaption lowercase,block_type()returnsCow<str>tests/conformance.rs) to prevent future spec driftTest plan
cargo build --workspace --all-featurespassescargo test --workspace --all-featurespasses (973 tests, 0 failures)cargo clippy --workspace --all-features -- -D warningsclean