-
Notifications
You must be signed in to change notification settings - Fork 124
Extend EVE plugin to handle popEVE data #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| my $class_key = "Class" . $self->{class_number}; | ||
|
|
||
| # prefer INFO descriptions pulled from VCF but fall back to hard-coded descriptions | ||
| my $h = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if only popEVE file is given they will be still be in the header.
| alts => [$variant->{alt}], | ||
| pos => $variant->{start}, | ||
| } | ||
| { ref => $ref_allele, alts => $alt_alleles, pos => $vf->{start}, strand => $vf->strand }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to keep the formatting same as before, as other plugins use the same format.
nakib103
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the other comments, it is also better to add -
- an example command for popEVE in the synopsis.
- instead of using Bio::DB::HTS can we hardcode the header? in some cases the user might not have installed the library and it would restrict them to use the plugin.
Description
This PR extends the VEP plugin
EVE.pmto be able to handle popEVE data. As such, the plugin can now annotate using EVE data OR popEVE data OR both.Main changes
popeve_filefileparameter as is - this param is still for the EVE filepopEVE_*fields when a popEVE record matches the user's input, and continues to emitEVE_*fields when an EVE record matchesget_matched_variant_allelesTesting
EVE.pmfor EVE/popEVE input file download and prep instructions, however, the EVE file is available on nfs atensembl/variation/data/EVEin.vcf:VEP command:
Output:
EVE_columns and 9popEVE_columns