Center the taskbar items #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-nu
reviewed
Dec 2, 2024
rick-nu
requested changes
Dec 2, 2024
Member
rick-nu
left a comment
rick-nu
left a comment
There was a problem hiding this comment.
Requested a small change, otherwise nice fix for off placement 👌
Member
Author
|
@rick-nu Updated the code 👍 please have a looksee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The taskbar items are centered on your screen.
Before this change they were left aligned in a wrapper of 72rem wide, which made it that they were visibly aligned slightly to the left of your monitor.
New situation:
Why
This makes the alignment nicer than before, now everything ties together nicely instead of having buttons being misaligned with the rest of the application.
This is more of a Windows 11 style approach, personally I would have gone for the traditional Windows 98/7/10 style by left aligning them, but I'm a traditional desktop guy still running XFCE 🙈 .
At any rate, they are nicely aligned now, and the responsiveness / behaviour on smaller screens is still exactly identical as before.