Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read the issue about compatibility with InfluxDB v2.0. As I needed this solved for my bachelor's thesis, I started on it myself. I copied the InfluxDB class and made the necessary changes to write and query data. By duplicating the existing class, all other code could be reused.
When the InfluxDB instance is created or the database is changed, a DataBase Retention Policy mapping is created to map the provided database name to a bucket with the same name. Before creating a new one, all existing mappings associated with the new database name are deleted to prevent any issues. This part is the only part that uses the new v2.0 API.
Next, I changed the
runWrite,runQuery, andrunCommandto use token-based authorization.I didn't know how to write correct tests, but I tested writing and querying manually and everything seemed to work. My test script is provided as an example.