This repository was archived by the owner on Apr 16, 2019. It is now read-only.
Add support for mixed case filenames #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in addition to pull request #29. Please consider pull request #29 first.
This change makes lowercase filenames optional. I'd personally prefer to see mixed case files, and leave the sorting up to the client. With this change, the case is maintained internally. There's a --lowercase option that creates a transform on the filenames (namely, calling lower()) just for the returning directory entries.
I also defined a few classes here, in part because it helped abstract this change by hiding transformations via lower() and the like. I think the end result is somewhat more "properly abstracted" code and whatnot. It could still be taken further, but I think it's a step forward.